[hcflinux] Re: [hylafax-devel] Re: HCF driver with Hylafax

[Lee Howard]

On 2002.05.28 22:15 Marc Boucher wrote:
> On Wed, May 29, 2002 at 12:56:26AM -0400, Alok K. Dhir wrote:

> > AT+FCLASS=?
> > +FCLASS:(0,1,1.0)

> faxaddmodem is confused by the +FCLASS: prefix in the modem's response;
> that's easy to fix (see patch below)

> --- faxaddmodem.ORIG	Wed May 29 01:01:55 2002
> +++ faxaddmodem	Wed May 29 01:08:46 2002
> @@ -1178,7 +1178,7 @@
>  echo ""
>  if [ "$RESULT" = "OK" ]; then
>      # Looks like a Class 1, 2, or 2.0 modem, get more information
> -    case "`echo $RESPONSE | $SED -e 's/[()]//g'`" in
> +    case "`echo $RESPONSE | $SED -e 's/\+FCLASS://' -e 's/[()]//g'`" in
>      1)			configureClass1Modem;;
>      2)			configureClass2Modem;;
>      2.0)		configureClass2dot0Modem;;

This section of code changed in HylaFAX CVS last week with the initial 
Class 2.1 support.  The particular usage of sed has not changed, but the 
manner in which the response is parsed has changed, and in this case 
HylaFAX CVS (to eventually become 4.1.3) will work just fine with the 
"+FCLASS:(0,1,1.0)" response to AT+FCLASS=?.  It would not have worked if 
the response were "+FCLASS:(1,1.0)".

Note, however, that if the HCF driver follows this pattern of reporting, 
i.e.:

AT+FTM=?
+FTM:(3,24,48,72,73,74,96,97,98,121,122,145,146)

that there will be further problems, and if it doesn't continue the 
pattern of reporting, then the exception in the case of +FCLASS=? seems 
unfortunate.

Lee.